simpler people components#29062
Merged
chrisnojima merged 4 commits intonojima/HOTPOT-next-670-cleanfrom Mar 31, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Refactors the People screen UI code to reduce repetition by introducing small reusable components/helpers for rendering todo tasks and item lists.
Changes:
- Consolidates multiple “todo” connector components into reusable
BasicTask,SwitchTabTask,SettingsAccountTask, andOpenURLTaskbuilding blocks. - Simplifies People list rendering by extracting
renderPeopleItem,shouldRenderNewItem, andPeopleItems. - Small behavioral-preserving cleanups (shared router selector hook, minor callback simplification).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
shared/people/todo.tsx |
Replaces many per-todo connector components with a small set of reusable task components and a shared router selector helper. |
shared/people/index.shared.tsx |
Extracts item rendering/filtering into helper functions/components to reduce inline JSX complexity. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
chrisnojima
force-pushed
the
nojima/ZCLIENT-people-simpler
branch
from
110f842 to
15b4e3e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.